Implement unary_ufunc functions using elementwise_util #9386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9386
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 7baa2f4 with merge base 71025df ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 19, 2025
Merged
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 19, 2025
|
this will get shuffled later in the stack |
| return out; | ||
| } | ||
|
|
||
| ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, op_name, CTYPE_IN, [&] { |
There was a problem hiding this comment.
this is a problem, right? the compute dtype here would be the input's scalar type,
There was a problem hiding this comment.
you need to switch over FLOATHBF16, right?
This was referenced May 28, 2025
swolchok
changed the base branch from
gh/swolchok/380/head
to
gh/swolchok/440/head
swolchok
commented
May 28, 2025
Comment on lines
+148
to
+151
| ScalarType compute_type = in.scalar_type() == ScalarType::Double | ||
| ? ScalarType::Double | ||
| : ScalarType::Float; | ||
| ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&] { |
There was a problem hiding this comment.
this is the only ET_SWITCH change remaining -- we are switching over the possible compute types, not the input/output types.
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
[ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util).