Implement unary_ufunc functions using elementwise_util #9386

swolchok · 2025-03-19T00:32:19Z

One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util).

[ghstack-poisoned]

swolchok · 2025-03-19T00:32:20Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-03-19T00:32:22Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9386

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 54 New Failures, 15 Unrelated Failures

As of commit 4a00cac with merge base a5d64cf ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
Lint / lintrunner / linux-job (gh)
RuntimeError: Command docker exec -t 01a88fc5b90098e653c17de921c63f2d56ee1244ebf4782f2d8c4101163ba290 /exec failed with exit code 1
pull / test-binary-size-linux / linux-job (gh)
RuntimeError: [2025-03-20T00:47:54.434+00:00] Build ID: 688f6ed4-5e42-4b0f-ba6d-c8a13a1f08c3
pull / test-binary-size-linux-gcc / linux-job (gh)
RuntimeError: [2025-03-20T00:47:54.536+00:00] Build ID: 16fe839b-2ce1-459f-9f05-88adbb088ece
pull / test-custom-ops-linux / linux-job (gh)
RuntimeError: Command docker exec -t a94d02159a8b72eab6ca5f63be9af137922a0404126efa66bb47860110d99656 /exec failed with exit code 1
pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t 3325d90f047c150fcd18500bcdbd87220a75683b74a824f8a2d2c9a027d1f8dd /exec failed with exit code 1
pull / test-eval_llama-wikitext-linux / linux-job (gh)
RuntimeError: Command docker exec -t 5f6b3ff9ef39f4623af03e33d5531e06a62843b40bfd157f33f02d7c26667d80 /exec failed with exit code 1
pull / test-llama_runner_eager-linux / linux-job (gh)
RuntimeError: Command docker exec -t d03f9fabbe1d08eb326c0ed2f6c49e8efb59ef9765980432e97efce7a811c866 /exec failed with exit code 1
pull / test-llama-runner-linux (bf16, custom, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh)
RuntimeError: Command docker exec -t d9559e8947950d09a1c90159dbde308b7754be2549f250c5110f1d6b1fde5438 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+qe, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh)
RuntimeError: Command docker exec -t 0ecf65b5486ee323924525860c5267348d846d35fab3e364755139028b388c13 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+qe, linux.arm64.2xlarge, executorch-ubuntu-22.04-gc... / linux-job (gh)
RuntimeError: Command docker exec -t 2cded11f75771d9f5aeb941013221c3dc705f08f6dd036fb18708ec844f9929c /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv, linux.2xlarge, executorch-ubuntu-22.04... / linux-job (gh)
RuntimeError: Command docker exec -t cf759e071dc7892cd7a3e7e4311ff476049fd0b2931088f4266739d647e1631c /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv, linux.arm64.2xlarge, executorch-ubuntu... / linux-job (gh)
RuntimeError: Command docker exec -t 97b608c544a051a3f75dca6aa5e40fe27b386f3e9fce3ca2e1425c36e95c7a19 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh)
RuntimeError: Command docker exec -t 0f224478c6b8522da93d264dfe53afc4da5016be3b072f09940879d457eb6cc1 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv, linux.arm64.2xlarge, executorch-ubuntu-22.04-... / linux-job (gh)
RuntimeError: Command docker exec -t 06f1c358d2b2bb19143ac2964641e834b63cf038c26343334e57332108c7f755 /exec failed with exit code 1
pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
RuntimeError: [2025-03-20T00:46:49.005+00:00] Build ID: 7953c345-718d-49ba-8390-a9553285f400
pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t aa4d634180207274375daaa6b3ed2bc4b7bfb607eac4e24959cbc057008e547e /exec failed with exit code 1
pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t e67ee89eae2b5f770a844d4b97eaa6fabcf1d065beb41a2ba715950a3f1c4aa7 /exec failed with exit code 1
pull / test-models-linux (add_mul, portable, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 0194a5d523759852d4fe9eef10fe0dd1cbfd4756437dcbd90287297144a62516 /exec failed with exit code 1
pull / test-models-linux (add_mul, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 1c76b7dace61f520a5c60b2237f11bff74659ef0b05138687d93d419dc41d652 /exec failed with exit code 1
pull / test-models-linux (add, portable, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t dbef185ab73162360d3df48e6c91aee877516357b8e7e2e666dca101d739a452 /exec failed with exit code 1
pull / test-models-linux (add, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 5434c3e01094c1f79b61bd316a81a85002078ad7d8b62d8de47023a83e8bca1f /exec failed with exit code 1
pull / test-models-linux (emformer_join, xnnpack-quantization-delegation, linux.4xlarge.memory) / linux-job (gh)
RuntimeError: Command docker exec -t e4f3d0be7a3b83819a9f96f780398473d7b5f86535a379da88a6d4f77fe4f16d /exec failed with exit code 1
pull / test-models-linux (emformer_transcribe, portable, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t e58a860eff8470032c27b81a318f7a62ea6d9b0d99e6cd9f7f234f23877f0563 /exec failed with exit code 1
pull / test-models-linux (ic3, portable, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t e8a636af719d9c0a7c6183d726c09c0ba8b856190dd395d09c01b8a0a63b24ca /exec failed with exit code 1
pull / test-models-linux (ic3, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 6dbdac5e077edd0d7df60f70703bbfbafcc43d6a26e0e36f1c5a9e52ca76ecd8 /exec failed with exit code 1
pull / test-models-linux (ic4, portable, linux.4xlarge.memory) / linux-job (gh)
RuntimeError: Command docker exec -t 709ada061dcdf6f205ed3ee6b5e5c9db4af56a79ef34b1fbdc967fb055ac8412 /exec failed with exit code 1
pull / test-models-linux (linear, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t a50ec605e1cc62a58c3cac96ad69ff82f02f740c0f8ea8f78cd9893ffa008aa8 /exec failed with exit code 1
pull / test-models-linux (llama3_2_vision_encoder, portable, linux.4xlarge.memory) / linux-job (gh)
RuntimeError: Command docker exec -t 276d81caa5af599f0b4b59806c34167ed0b6ec01ced82d58df481c426b37b270 /exec failed with exit code 1
pull / test-models-linux (mobilebert, portable, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t ddbfc81a5f88cdabb2a9eb4bae3a4a2bd81beac7a7de0904549d49d7f5b58538 /exec failed with exit code 1
pull / test-models-linux (mobilebert, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 9b64361d08877eb97ebbd16f9e10b45903431193bcd60196b779c157e18fe2af /exec failed with exit code 1
pull / test-models-linux (mv2, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 307f9de80186a3920852592073d11ae5afa25446e3172ce34e6526afe5d3ab07 /exec failed with exit code 1
pull / test-models-linux (phi-4-mini, portable, linux.4xlarge.memory) / linux-job (gh)
RuntimeError: Command docker exec -t e1424e4474b82e843f6a414b4a50f22cfb478f4ba3056e64125adc69c6f1b1e0 /exec failed with exit code 1
pull / test-models-linux (resnet18, portable, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t a10761bced0d7657dc98b0a28171f44214e0c3f8d4b0e290df8c55e44c885282 /exec failed with exit code 1
pull / test-models-linux (resnet18, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 8dc2312d8fcafa99ae0b7871922407b6d3a4bb8a5af3453378ccaf2fb449be47 /exec failed with exit code 1
pull / test-models-linux (resnet50, portable, linux.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 1a9993e07189cd98fd3ad50f26ee0aed2d88dd0d0ad495455b7000952915040c /exec failed with exit code 1
pull / test-models-linux (w2l, portable, linux.4xlarge.memory) / linux-job (gh)
RuntimeError: Command docker exec -t b00442890b5ba7bc51fba971be49b798d4cef3799ec01254c431199f1a376ada /exec failed with exit code 1
pull / test-models-linux-basic (mv3, portable, buck2, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh)
RuntimeError: Command docker exec -t c99d40eada005d8ee7989c6bb96e30bfc109388f47251e1c733341056788274d /exec failed with exit code 1
pull / test-models-linux-basic (mv3, portable, cmake, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh)
RuntimeError: Command docker exec -t 35e874ea472fb6200665108a1919ef64ad6f93d0345bff11fd04d6b74563309a /exec failed with exit code 1
pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh)
RuntimeError: Command docker exec -t 316f787eeb9f5b803d7761ef5385a80aca5fee2006d212bdd85398ff325eec8f /exec failed with exit code 1
pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, cmake, linux.2xlarge, executorch-u... / linux-job (gh)
RuntimeError: Command docker exec -t f4c165c3227a26cae461c9552b853484b0b0605490be0ab60d6b086420e8507e /exec failed with exit code 1
pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, cmake, linux.arm64.2xlarge, execut... / linux-job (gh)
RuntimeError: Command docker exec -t 95abec98ad21138486b7e96a885b5354728b984541c4907a2c396d14afe01eb0 /exec failed with exit code 1
pull / test-models-linux-basic (vit, portable, cmake, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh)
RuntimeError: Command docker exec -t 7f03b2a5fd4d91c11b6b0086d3d412170b05bda5aae40f0c19012af5ad1b7690 /exec failed with exit code 1
pull / test-models-linux-basic (vit, portable, cmake, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11... / linux-job (gh)
RuntimeError: Command docker exec -t 95233c85c600aa19cd6b1606684524092c52ae88b59a4f68d4407dfc8ba3ba77 /exec failed with exit code 1
pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, cmake, linux.arm64.2xlarge, execut... / linux-job (gh)
RuntimeError: Command docker exec -t 8bd9e5100734841a669a4e6503cc0152f1eff743644576488717939e04db4ad8 /exec failed with exit code 1
pull / test-pybind-build-linux / linux-job (gh)
RuntimeError: Command docker exec -t 5f411fac5dc0a48351df1d7171e844c7f6d0f5deae6f7853eb51c694db8ccad8 /exec failed with exit code 1
pull / test-quantized-aot-lib-linux / linux-job (gh)
RuntimeError: Command docker exec -t 4493449662a5f95586fc872196b3ceb54c19cd5a327c62170961d055170a6495 /exec failed with exit code 1
pull / test-selective-build-linux / linux-job (gh)
RuntimeError: Command docker exec -t b019b7dbe0c5065f4ba476836f3dce56b16c09eabaab81aaedda74f725bf4ae8 /exec failed with exit code 1
pull / test-setup-linux-gcc / linux-job (gh)
RuntimeError: Command docker exec -t b2ad7fa1483e3b564a876271c01d4f24a79933db47d5f7e99dab0366af70f90c /exec failed with exit code 1
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / unittest-buck / linux / linux-job (gh)
RuntimeError: Command docker exec -t 1abd03e34564af1cc8205d36c2affdf4466dd7a10d409a6842147bfab710064b /exec failed with exit code 1
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 3
pull / unittest-editable / linux / linux-job (gh)
RuntimeError: Command docker exec -t f9e487ad56603c1d6d2679f2b7e538e910dfb4f793ce6338f2b37fa763b0a014 /exec failed with exit code 1
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-llama-runner-linux-android / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (emformer_join, portable, linux.4xlarge.memory) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (emformer_transcribe, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (ic4, xnnpack-quantization-delegation, linux.4xlarge.memory) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (linear, portable, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (mv2, portable, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux (resnet50, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux-basic (mv3, portable, cmake, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11... / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux-basic (vit, portable, buck2, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, cmake, linux.2xlarge, executorch-u... / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-phi-3-mini-runner-linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / test-static-llama-qnn-linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / unittest / linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
pull / unittest-arm / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

swolchok · 2025-03-25T16:47:22Z

this will get shuffled later in the stack

manuelcandales · 2025-03-28T20:31:13Z

kernels/portable/cpu/pattern/pattern.h

+    return out;
+  }
+
+  ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, op_name, CTYPE_IN, [&] {


this is a problem, right? the compute dtype here would be the input's scalar type,

you need to switch over FLOATHBF16, right?

Update

29d6de9

[ghstack-poisoned]

swolchok requested a review from manuelcandales as a code owner March 19, 2025 00:32

This was referenced Mar 19, 2025

Make PyTorch headers available in optimized_portable_kernels, define ET_USE_PYTORCH_HEADERS #9384

Merged

elementwise_util: don't cast the result of compute_fun back to the common type #9385

Draft

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025

This was referenced Mar 19, 2025

Refactor elementwise_util: create variants with out_dtypes in template argument list #9387

Merged

RFC: Specialize for non-mixed-dtype in elementwise_util #9388

Merged

Update

7c78357

[ghstack-poisoned]

swolchok mentioned this pull request Mar 19, 2025

Vectorize optimized_portable_ops versions of portable ops? #9241

Open

Update

4a00cac

[ghstack-poisoned]

This was referenced Mar 20, 2025

BroadcastIndexesRange: leading 1s don't require true broadcasting #9431

Merged

Add vectorization in elementwise_util #9432

Open

swolchok marked this pull request as draft March 28, 2025 20:28

manuelcandales reviewed Mar 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement unary_ufunc functions using elementwise_util #9386

Implement unary_ufunc functions using elementwise_util #9386

Uh oh!

swolchok commented Mar 19, 2025

Uh oh!

swolchok commented Mar 19, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 19, 2025 •

edited

Loading

Uh oh!

swolchok commented Mar 25, 2025

Uh oh!

manuelcandales Mar 28, 2025

Uh oh!

manuelcandales Mar 28, 2025

Uh oh!

Uh oh!

Implement unary_ufunc functions using elementwise_util #9386

Are you sure you want to change the base?

Implement unary_ufunc functions using elementwise_util #9386

Uh oh!

Conversation

swolchok commented Mar 19, 2025

Uh oh!

swolchok commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9386

❌ 54 New Failures, 15 Unrelated Failures

Uh oh!

swolchok commented Mar 25, 2025

Uh oh!

manuelcandales Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

manuelcandales Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swolchok commented Mar 19, 2025 •

edited

Loading

pytorch-bot bot commented Mar 19, 2025 •

edited

Loading